EPUB/Snapshot: Override print options to correct title & URL #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This specific PR looks good. However, I have an issue with one EPUB file where all printed pages are empty (I will send a link). |
AbeJellinek
force-pushed
the
4818-epub-snapshot-print-title-url
branch
from
7f30a1d to
5c9dfda
Compare
AbeJellinek
force-pushed
the
4818-epub-snapshot-print-title-url
branch
from
5c9dfda to
a47febd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPUBs can show the book title (disabled by default) but don't have any URL. Snapshots show the page title and the URL they were imported from.
Needs zotero/zotero#4820, fixes zotero/zotero#4818